How about the following? Reworded in a way such that 0 means no and 1 means yes. +static uint optimize_stpg; +module_param(optimize_stpg, uint, S_IRUGO|S_IWUSR); +MODULE_PARM_DESC(optimize_stpg, "Allow use of a non-optimized path, rather than sending a STPG, when implicit TPGS is supported (0=No,1=Yes). Default is 0."); Thanks, Sean Stewart -----Original Message----- From: Ewan Milne [mailto:emilne@xxxxxxxxxx] Sent: Monday, April 01, 2013 9:25 AM To: Stewart, Sean Cc: linux-scsi@xxxxxxxxxxxxxxx; dm-devel@xxxxxxxxxx; James.Bottomley@xxxxxxx; snitzer@xxxxxxxxxx; hare@xxxxxxx Subject: Re: [PATCH] scsi_dh_alua: Add module parameter to allow failover to non preferred path without STPG On Thu, 2013-03-28 at 22:07 +0000, Stewart, Sean wrote: > +static uint optimize_stpg; > +module_param(optimize_stpg, uint, S_IRUGO|S_IWUSR); > +MODULE_PARM_DESC(optimize_stpg, "Send STPG command for Failover on > +non-preferred path(0=Yes,1=No). Default is 0."); Could you possibly reword the description? When I first read this, it seemed backwards to have 0=Yes and 1=No. -Ewan D. Milne <emilne@xxxxxxxxxx> ��.n��������+%������w��{.n�����{������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
