Il 12/11/2012 16:10, James Bottomley ha scritto:
>> Actually it only turns it on for large capacity drives, as said in the
>> comment. sdp->force_read_16 only matters for >2TB drives:
>
> If you follow the discussion, we'll need to turn it on for some drives
> regardless of size.
Even if the two reasons to use r/w(16) commands were setting the same
flag, it would be handled in a separate patch; it doesn't really make
sense to complicate the code now when a one-liner does it.
The proposed change is not part of the Oct 31st draft available on
t10.org, for what we know the discussion could end up in nothing.
>> > Any reason not to do this always on >2TB drives, which basically means
>> > changing this:
>> >
>> > - } else if (block > 0xffffffff) {
>> > + } else if (sdkp->capacity > 0xffffffff) {
>> >
>> > and nothing else?
> Because of the coming T10 mandate in SBC-4 deprecating everything other
> than the 16 byte commands.
And would this change make the upcoming patch for SBC-4 support longer
or harder to review?
Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
