On 09/19/2012 05:49 PM, Mike Christie wrote: > On 08/24/2012 04:08 AM, Bart Van Assche wrote: >> A quote from SPC-4: "While in the unavailable primary target port >> asymmetric access state, the device server shall support those of >> the following commands that it supports while in the active/optimized >> state: [ ... ] d) SET TARGET PORT GROUPS; [ ... ]". Hence enable >> sending STPG to a target port group that is in the unavailable state. >> >> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx> >> Cc: Hannes Reinecke <hare@xxxxxxx> >> Cc: Mike Christie <michaelc@xxxxxxxxxxx> >> Cc: Mike Snitzer <snitzer@xxxxxxxxxx> >> Cc: Babu Moger <babu.moger@xxxxxxxxxx> >> Cc: <stable@xxxxxxxxxxxxxxx> >> --- >> drivers/scsi/device_handler/scsi_dh_alua.c | 3 +-- >> 1 files changed, 1 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c >> index 08d80a6..a05d469 100644 >> --- a/drivers/scsi/device_handler/scsi_dh_alua.c >> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c >> @@ -641,8 +641,7 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_dh_data *h) >> h->state = TPGS_STATE_STANDBY; >> break; >> case TPGS_STATE_OFFLINE: >> - case TPGS_STATE_UNAVAILABLE: >> - /* Path unusable for unavailable/offline */ >> + /* Path unusable */ >> err = SCSI_DH_DEV_OFFLINED; >> break; >> default: >> > > Hey, was this patch ok Hannes and James and others? > > I see bb2c94a3a6ad37fe7d34f369295bcdf5387e264f was merged, but this one > was not. > > I was thinking this might have got missed because it has the same patch > description as bb2c94a3a6ad37fe7d34f369295bcdf5387e264f, so it is > confusion, but they are different patches. One fixes alua_rtpg and one > fixes alua_activate, but both are needed. > Yeah, patch's okay. Acked-by: Hannes Reinecke <hare@xxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
