Re: [resend PATCH] scsi_remove_target: fix softlockup regression on hot remove

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2012-08-29 at 06:50 +0000, Bart Van Assche wrote:
> On 08/29/12 05:12, Dan Williams wrote:
> > John reports:
> >  BUG: soft lockup - CPU#2 stuck for 23s! [kworker/u:8:2202]
> >  [..]
> >  Call Trace:
> >   [<ffffffff8141782a>] scsi_remove_target+0xda/0x1f0
> >   [<ffffffff81421de5>] sas_rphy_remove+0x55/0x60
> >   [<ffffffff81421e01>] sas_rphy_delete+0x11/0x20
> >   [<ffffffff81421e35>] sas_port_delete+0x25/0x160
> >   [<ffffffff814549a3>] mptsas_del_end_device+0x183/0x270
> > 
> > ...introduced by commit 3b661a9 "[SCSI] fix hot unplug vs async scan race".
> 
> Including that call stack in the patch description may create the
> misleading impression that this only occurs with the mptsas driver. This
> lockup also happens with at least the iSCSI initiator. See also
> http://lkml.org/lkml/2012/8/24/340.

I don't think it does that.  The title is pretty generic, but you're
right the impact is potentially all scsi_remove_target() users.

> By the way, in order to get a patch in the stable tree the proper "Cc:"
> tag should be added in the patch description but the
> stable@xxxxxxxxxxxxxxx e-mail address should be left out from the
> Cc-list of the e-mail with the patch.

No, we talked about that at kernel summit.  It's ok for the stable@
alias to get a few extra mails.  The patch won't be applied until it
hits mainline and in the meantime it gives a heads up to the -stable
folks, or anyone that wants to follow up on stable patches making their
way to mainline.

--
Dan


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux