Re: [PATCH] scsi_dh_alua: Enable STPG for unavailable ports

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Aug 24, 2012, at 4:08 AM, Bart Van Assche <bvanassche@xxxxxxx> wrote:
> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
> index 08d80a6..a05d469 100644
> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
> @@ -641,8 +641,7 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_dh_data *h)
> 		h->state = TPGS_STATE_STANDBY;
> 		break;
> 	case TPGS_STATE_OFFLINE:
> -	case TPGS_STATE_UNAVAILABLE:
> -		/* Path unusable for unavailable/offline */
> +		/* Path unusable */
> 		err = SCSI_DH_DEV_OFFLINED;
> 		break;
> 	default:

We must not have tested unavailable state very much. 3rd bug in a short time. Looks ok to me.

Reviewed-by: Mike Christie <michaelc@xxxxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux