On 15 May 2012 10:59, Namjae Jeon <linkinjeon@xxxxxxxxx> wrote: > 2012/5/15, Girish K S <girish.shivananjappa@xxxxxxxxxx>: >> On 15 May 2012 09:02, Namjae Jeon <linkinjeon@xxxxxxxxx> wrote: >>> 2012/5/15, Girish K S <girish.shivananjappa@xxxxxxxxxx>: >>>> Sorry , >>>> I will rebase them to James' for-next treee. and resend >>>> >>>> thanks and regards >>>> Girish K S >>> There is one more thing. >>> You add your module author name. >>> But module author name should be only one per one module. >>> Your author name will be comflicted with origianl author(santosh, >>> vinayak). >>> plz try to check like this. maybe you can see your name instread >>> original author. >>> /sbin/modinfo ufshcd.ko >> If i build ufshcd.ko ufshcd-pci.ko ufshcd-pltfm.ko, then i can see >> only my name in the ufshcd-*.ko which is added by me. But not in >> ufshcd.ko >> Is it a problem? > ufsdhcd(interface core driver), ufshcd-pci and ufshcd-pltm drivers can > be divided as your suggestion. > And I think that it looks proper to me if you add original author to > ufschd.ko and ufschd-pci.ko. > And you can add your name to ufshcd-pltm.ko. > Because this driver is made by your idea. Sure will do that in the patch which i resend > Thanks. > >>> >>> Thanks. >>>> >>>> On 15 May 2012 07:08, Namjae Jeon <linkinjeon@xxxxxxxxx> wrote: >>>>> Hi. Girish. >>>>> >>>>> There are hunks when I try to patch. >>>>> have you created patches on linux-next ? >>>>> >>>>> patching file drivers/scsi/ufs/ufs.h >>>>> patching file drivers/scsi/ufs/ufshcd.c >>>>> Hunk #10 FAILED at 826. >>>>> Hunk #13 FAILED at 929. >>>>> Hunk #15 succeeded at 1050 with fuzz 1 (offset 2 lines). >>>>> Hunk #17 succeeded at 1193 (offset 2 lines). >>>>> Hunk #19 succeeded at 1392 (offset 2 lines). >>>>> Hunk #21 succeeded at 1571 (offset 2 lines). >>>>> Hunk #23 succeeded at 1644 (offset 2 lines). >>>>> Hunk #25 FAILED at 1724. >>>>> 3 out of 25 hunks FAILED -- saving rejects to file >>>>> drivers/scsi/ufs/ufshcd.c.rej >>>>> >>>>> And after testing, have you sent this patch ? >>>>> >>>>> Thanks. >>>>> >>>>> 2012/5/14, Girish K S <girish.shivananjappa@xxxxxxxxxx>: >>>>>> The existing UFS driver is tightly bound to only pci specific devices. >>>>>> It cannot work for non-pci devices. >>>>>> >>>>>> "SCSI: UFS: remove all pci code from core driver" patch removes all >>>>>> the >>>>>> pci specific code from the core driver to make it generic >>>>>> >>>>>> "SCSI: UFS: Add support for pci probe" patch adds a new file to >>>>>> support >>>>>> pci probing. >>>>>> >>>>>> "SCSI: UFS: Add platform support for ufs host controller" patch adds a >>>>>> new >>>>>> file to support platform device probe >>>>>> >>>>>> "SCSI: UFS: Added support of PCI/PLTFM for UFS" patch adds the menu >>>>>> option >>>>>> in Kconfig and Makefile to enable/disable the specific option >>>>>> >>>>>> Girish K S (4): >>>>>> SCSI: UFS: remove all pci code from core driver >>>>>> SCSI: UFS: Add support for pci probe >>>>>> SCSI: UFS: Add platform support for ufs host controller >>>>>> SCSI: UFS: Added support of PCI/PLTFM for UFS >>>>>> >>>>>> drivers/scsi/ufs/Kconfig | 32 +++- >>>>>> drivers/scsi/ufs/Makefile | 2 + >>>>>> drivers/scsi/ufs/ufs.h | 103 +++++++++++ >>>>>> drivers/scsi/ufs/ufshcd-pci.c | 217 ++++++++++++++++++++++ >>>>>> drivers/scsi/ufs/ufshcd-pltfm.c | 191 ++++++++++++++++++++ >>>>>> drivers/scsi/ufs/ufshcd.c | 377 >>>>>> +++++++++------------------------------ >>>>>> 6 files changed, 623 insertions(+), 299 deletions(-) >>>>>> create mode 100644 drivers/scsi/ufs/ufshcd-pci.c >>>>>> create mode 100644 drivers/scsi/ufs/ufshcd-pltfm.c >>>>>> >>>>>> -- >>>>>> 1.7.4.1 >>>>>> >>>>>> -- >>>>>> To unsubscribe from this list: send the line "unsubscribe linux-scsi" >>>>>> in >>>>>> the body of a message to majordomo@xxxxxxxxxxxxxxx >>>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>>>>> >>>> >> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
