-----Original Message----- >From: James Bottomley [mailto:James.Bottomley@xxxxxxxxxxxxxxxxxxxxx] >Sent: Wednesday, April 25, 2012 1:13 AM >To: michaelc@xxxxxxxxxxx >Cc: linux-scsi@xxxxxxxxxxxxxxx; Kallickal, Jayamohan; John, Sony >Subject: Re: [PATCH 07/17] be2iscsi:Fix double free of MCCQ info memory. >On Tue, 2012-04-03 at 23:41 -0500, michaelc@xxxxxxxxxxx wrote: > Subject: [PATCH 07/17] be2iscsi:Fix double free of MCCQ info memory. >Needs a space after the colon. I've been fixing it up on import, so this is for future reference. > From: Jayamohan Kallickal <jayamohan.kallickal@xxxxxxxxxx> >This from doesn't match the first signoff ... is this the right from field? > In case of MCC_Q creation failed, the MCCQ info memory is freed from > be_mcc_queues_destroy and be_mcc_queues_create. This caused kernel to > panic because of double free. >The extra space here needs removing (I've been doing it on import) > Signed-off-by: John Soni Jose <sony.john-n@xxxxxxxxxx> dd >dd? Is this just a spurious addition or should there be something else here? > Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@xxxxxxxxxx> > Signed-off-by: Mike Christie <michaelc@xxxxxxxxxxx> >James The From: should have been John Soni Jose <sony.john-n@xxxxxxxxxx> as the patch is originally prepared by Sony. The signed-off order is right and the dd must have creeped in while eyeballing the patch and multitasking. Thanks for taking care of the space issues. Will verify that for the next round of patches Jay ��.n��������+%������w��{.n�����{������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
