2012/4/23 Santosh Y <santoshsy@xxxxxxxxx>: > From: Santosh Yaraganavi <santoshsy@xxxxxxxxx> > > UTP Transfer request list base registers UTRLBA and UTRLBAU > must be assigned, lower-32 and upper-32 bits of UTRLD list > physical base addresses respectively. > > Currently UTRLBAU is being assigned lower-32 bits of UTRLD > physical base address. This will cause an issue with > controllers that can support 64-bit addressing. > > This patch correctly assigns upper-32 bits of UTRLD physical > base address to UTRLBAU. Hi. Santosh. 0 : 9 bits are reserved in UTRLBA of specification. is it considered also ? Thanks. > > Reported-by: Rene De Jong <rene.dejong@xxxxxxx> > Signed-off-by: Santosh Yaraganavi <santoshsy@xxxxxxxxx> > Reviewed-by: Vinayak Holikatti <vinholikatti@xxxxxxxxx> > --- > drivers/scsi/ufs/ufshcd.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 52b96e8..ea32ade 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -1032,11 +1032,11 @@ static int ufshcd_initialize_hba(struct ufs_hba *hba) > return -EIO; > > /* Configure UTRL and UTMRL base address registers */ > - writel(hba->utrdl_dma_addr, > - (hba->mmio_base + REG_UTP_TRANSFER_REQ_LIST_BASE_L)); > writel(lower_32_bits(hba->utrdl_dma_addr), > + (hba->mmio_base + REG_UTP_TRANSFER_REQ_LIST_BASE_L)); > + writel(upper_32_bits(hba->utrdl_dma_addr), > (hba->mmio_base + REG_UTP_TRANSFER_REQ_LIST_BASE_H)); > - writel(hba->utmrdl_dma_addr, > + writel(lower_32_bits(hba->utmrdl_dma_addr), > (hba->mmio_base + REG_UTP_TASK_REQ_LIST_BASE_L)); > writel(upper_32_bits(hba->utmrdl_dma_addr), > (hba->mmio_base + REG_UTP_TASK_REQ_LIST_BASE_H)); > -- > 1.7.5.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
