On Wed, 2012-03-07 at 15:04 +0530, Nandigama, Nagalakshmi wrote: > -----Original Message----- > From: James Bottomley [mailto:James.Bottomley@xxxxxxxxxxxxxxxxxxxxx] > Sent: Wednesday, March 07, 2012 6:13 AM > To: Nandigama, Nagalakshmi > Cc: stable@xxxxxxxxxxxxxxx; linux-scsi > Subject: Re: [RESEND PATCH] mptsas: Fixed code to check whether the LU type is SSC or not for SILI bit in READ_6 and READ_16 CDB > > On Tue, 2012-03-06 at 12:16 +0530, nagalakshmi.nandigama@xxxxxxx wrote: > >> This SILI bit (suppress incorrect length indicator) is defined only for SSC > >> READ(6) and READ(16) commands. For other device types bit is part of LBA > > >This isn't right ... it is for READ(6) but it's FUA_NV for > >READ(10,12,16) on block devices. > > > For READ6, READ16 SSC commands, the BIT 1of BYTE 2 is SILI. (As per SSC4 specs) > For block commands, the BIT 1of BYTE 2 is part of LBA for READ6 and FUA_NV bit for > READ(10,12,16). > > So it is required to check whether the logical unit is SSC device or not when checking SILI bit. > So in the patch which I sent, I added this piece of code. That's what the standards say, yes, I know that. If there's a visible bug, this is the description of the cause. What I'm asking is what is the actual user visible effect? The change log needs to include that to give people who read it an idea of why they might need to apply the fix. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
