James/linux-scsi, The following patch for megaraid_sas removes an incorrect comment and optimizes the setting of HostMSIxVectors. This was found during a code review by Tomas Henzl @ RedHat. Signed-off-by: Adam Radford <aradford@xxxxxxxxx> diff -Naur scsi-misc-2.6/drivers/scsi/megaraid/megaraid_sas_fusion.c scsi-misc-2.6.new/drivers/scsi/megaraid/megaraid_sas_fusion.c --- scsi-misc-2.6/drivers/scsi/megaraid/megaraid_sas_fusion.c 2012-03-19 17:39:08.313986900 -0700 +++ scsi-misc-2.6.new/drivers/scsi/megaraid/megaraid_sas_fusion.c 2012-03-19 17:44:14.901863036 -0700 @@ -634,9 +634,7 @@ fusion->reply_frames_desc_phys; IOCInitMessage->SystemRequestFrameBaseAddress = fusion->io_request_frames_phys; - /* Set to 0 for none or 1 MSI-X vectors */ - IOCInitMessage->HostMSIxVectors = (instance->msix_vectors > 0 ? - instance->msix_vectors : 0); + IOCInitMessage->HostMSIxVectors = instance->msix_vectors; init_frame = (struct megasas_init_frame *)cmd->frame; memset(init_frame, 0, MEGAMFI_FRAME_SIZE);
Attachment:
megaraid_sas.patch1
Description: Binary data
