On Sat, Mar 10, 2012 at 8:39 PM, Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
> eh is woken up automatically by the presence of failed commands,
> scsi_schedule_eh is reserved for cases where there are no failed
> commands. This guarantees that host_eh_sceduled is only incremented
> when an explicit eh request is made.
>
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> ---
> drivers/scsi/libsas/sas_ata.c | 25 -------------------------
> drivers/scsi/libsas/sas_scsi_host.c | 5 -----
> include/scsi/sas_ata.h | 4 ----
> 3 files changed, 0 insertions(+), 34 deletions(-)
>
> diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
> index bc0cecc..729a7b6 100644
> --- a/drivers/scsi/libsas/sas_ata.c
> +++ b/drivers/scsi/libsas/sas_ata.c
> @@ -574,31 +574,6 @@ int sas_ata_init_host_and_port(struct domain_device *found_dev)
> return 0;
> }
>
> -void sas_ata_task_abort(struct sas_task *task)
> -{
> - struct ata_queued_cmd *qc = task->uldd_task;
> - struct completion *waiting;
> -
> - /* Bounce SCSI-initiated commands to the SCSI EH */
> - if (qc->scsicmd) {
> - struct request_queue *q = qc->scsicmd->device->request_queue;
> - unsigned long flags;
> -
> - spin_lock_irqsave(q->queue_lock, flags);
> - blk_abort_request(qc->scsicmd->request);
> - spin_unlock_irqrestore(q->queue_lock, flags);
> - scsi_schedule_eh(qc->scsicmd->device->host);
Although we don't need this call to scsi_schedule_eh, we certainly
need to handle task->uldd_task differently for ata tasks, will resend.
--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
