Hello Nicholas,
The patch b3fd3cce29bb: "tcm_qla2xxx: Add >= 24xx series fabric
module for target-core" from Mar 8, 2012, leads to the following Sparse
warning:
drivers/scsi/qla2xxx/tcm_qla2xxx.c:843:37: warning: right shift by
bigger than source value
+ domain = (nacl->nport_id >> 16) & 0xff;
^^^^^^^^
nport_id is a u16 so this is always zero.
+ area = (nacl->nport_id >> 8) & 0xff;
+ al_pa = nacl->nport_id & 0xff;
[snip]
+struct tcm_qla2xxx_nacl {
+ /* From libfc struct fc_rport->port_id */
+ u16 nport_id;
fc_rport->port_id is a u32.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
