On Mon, Mar 12, 2012 at 04:09:31PM -0700, Robert Love wrote:
> +static void fcoe_ctlr_attrs_release(struct device *dev)
> +{
> + struct fcoe_ctlr_attrs *ctlr = dev_to_ctlr(dev);
> +
> + put_device(ctlr->dev.parent);
> + ctlr->dev.parent = NULL;
You should never have to put a reference count on your parent, nor worry
about setting this value to NULL. Just assign the parent when you
register the device, no need to increment it.
> +#define fcoe_ctlr_id(x) \
> + ((x)->id)
> +#define fcoe_ctlr_work_q_name(x) \
> + ((x)->work_q_name)
<snip>
Ick, what are all of these for, please don't do that.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
