>>>>> "Eric" == Eric Sandeen <sandeen@xxxxxxxxxx> writes: Eric> While we're talking about names, looking at other scsi_debug_* Eric> flags should it be lbprz / scsi_debug_lbprz / DEF_LBPRZ instead of Eric> unmap_zeroes / scsi_debug_unmap_zeroes / DEF_UNMAP_ZEROES? Yeah, that's more consistent with my recent updates which use the lbpfoo flag names. >> Ah, and inquiry_evpd_b2() should return 4 (not 8). Eric> Is that at all related to this change or some other random bug? Eric> Should that return be unconditional? Should that be a separate Eric> patch? By someone who knows what it means? :) The returned page length should not include the length of the header. I mess that up all the time. The spec says: "If the DP bit is set to zero, then the page length shall be set to 0004h." The memset also needs to be fixed accordingly. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
