On Feb 14 Jun'ichi Nomura wrote: > According to the comments by Huajun Li: > http://www.spinics.net/lists/linux-scsi/msg55698.html > > The following commit has changed __blkdev_get() to end up calling > sd_revalidate_disk() without getting a refcount of scsi_device: > > commit 1196f8b814f32cd04df334abf47648c2a9fd8324 > Author: Tejun Heo <tj@xxxxxxxxxx> > Date: Thu Apr 21 20:54:45 2011 +0200 > > block: rescan partitions on invalidated devices on -ENOMEDIA too > > that could lead to oops like this: > > process A process B > ---------------------------------------------- > sys_open > __blkdev_get > sd_open > returns -ENOMEDIUM > scsi_remove_device > <scsi_device torn down> > rescan_partitions > sd_revalidate_disk > <oops> > > Should "revalidate_disk" of block_device_operations work > without successful open()? > > If so, sd_revalidate_disk() (and possibly other drivers) needs to be > fixed. (e.g. use scsi_disk_get/put by itself) > > If not, __blkdev_get() or rescan_partision() should avoid calling > "revalidate_disk" for -ENOMEDIUM case. It may very well be that not only sd_revalidate_disk is affected. I have yet to check whether the "open -> unplug -> ioctl -> oops" bug from http://www.spinics.net/lists/linux-scsi/msg56254.html (a) happens under 3.3-rc still (was reported against 3.2-rc7), (b) affects sd devices too (was reported against sr devices). -- Stefan Richter -=====-===-- --=- -===- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
