On Mon, 2012-02-13 at 14:36 -0500, Mike Snitzer wrote: > On Mon, Feb 13 2012 at 2:16pm -0500, > Martin K. Petersen <martin.petersen@xxxxxxxxxx> wrote: > > > >>>>> "Mike" == Mike Snitzer <snitzer@xxxxxxxxxx> writes: > > > > >> I don't have a fundamental problem with your patch. But since we > > >> explicitly handle ILLEGAL REQUEST with 0x20 and 0x24 in sd.c I wonder > > >> what's broken? We should disable discard support if the WRITE SAME w/ > > >> UNMAP fails. > > > > Mike> Yeah, I thought the disabling would be sufficient too. But > > Mike> unfortunately multipath doesn't inspect the request it is retrying > > Mike> (after it fails the path the request just failed on). > > > > Well, we shouldn't be returning something that multipath should ever act > > on. > > > > I think I understand what's going on. Can you try the following patch? > > Looks good to me (small nit below), it'll solve the immediate problem, > I'll pass it on. Please add my: > > Acked-by: Mike Snitzer <snitzer@xxxxxxxxxx> > > But I also think establishing a baseline of TARGET_ERROR for certain > ILLEGAL REQUEST is still sane and should go in too... So someone still needs to package up the final agreed version with a nice changelog and send it to the list ... James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
