On Tue, Dec 06 2011 at 5:03pm -0500, Martin K. Petersen <martin.petersen@xxxxxxxxxx> wrote: > >>>>> "Mike" == Mike Snitzer <snitzer@xxxxxxxxxx> writes: > > Mike> Regardless, shouldn't the SCSI midlayer classify such > Mike> ILLEGAL_REQUEST sense, with an add. sense I listed in the patch, > Mike> as a target error? > > Well, even SUCCESS should cause the I/O to be aborted. As I replied to James, yes SUCCESS does cause the IO to fail, but the discard gets retried by multipath. Returning TARGET_ERROR enables the block layer to return -EREMOTEIO which multipath will immediately pass up (rather than the normal fail path and retry). > I assume this is the RHEL6 kernel? Did you backport my provisioning > updates that brings the heuristics in sync with SBC-3 (#c98a0e)? Yes, that update was pulled in to RHEL6.2 (released today). But this issue is a concern for both upstream and RHEL6 (and any other distro with a recent kernel). -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html