On 12/01/12 7:31 AM, "Mike Christie" <michaelc@xxxxxxxxxxx> wrote: >On 01/11/2012 04:44 AM, vikas.chaudhary@xxxxxxxxxx wrote: >> >> -int ql4xextended_error_logging = 0; /* 0 = off, 1 = log errors */ >> +int ql4xextended_error_logging = 0; > >You do not need to init this to 0 like above. It gets set to zero for >you. I think this is some codingstyle doc rule violation. You should run >checkpatch.pl on your patches before sending to catch this type of stuff. > >It is probably ok since it was there before and you are not adding it >and your patch is focused on other stuff, but you should clean it up one >day and make note of it for the future. Yes, I will send separate cleanup patch for this type of codingstyle doc rule violation. This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
