Re: [PATCH 6/7] qla4xxx: Cleanup modinfo display

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/11/2012 04:44 AM, vikas.chaudhary@xxxxxxxxxx wrote:
>  
> -int ql4xextended_error_logging = 0; /* 0 = off, 1 = log errors */
> +int ql4xextended_error_logging = 0;

You do not need to init this to 0 like above. It gets set to zero for
you. I think this is some codingstyle doc rule violation. You should run
checkpatch.pl on your patches before sending to catch this type of stuff.

It is probably ok since it was there before and you are not adding it
and your patch is focused on other stuff, but you should clean it up one
day and make note of it for the future.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux