The patch seem to be fine. Please consider this patch as an Acked by me Regards, Nagalakshmi -----Original Message----- From: Anton Blanchard [mailto:anton@xxxxxxxxx] Sent: Monday, November 07, 2011 4:35 PM To: Desai, Kashyap Cc: Moore, Eric; JBottomley@xxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx Subject: Re: [SCSI] mpt2sas: _scsih_smart_predicted_fault uses GFP_KERNEL in interrupt context Hi Kashyap, On Sun, 31 Jul 2011 19:29:09 +1000 Anton Blanchard <anton@xxxxxxxxx> wrote: > > _scsih_smart_predicted_fault is called in an interrupt and therefore > must allocate memory using GFP_ATOMIC. Just noticed this hasn't made it upstream, any chance you could review it for merging? Anton -- _scsih_smart_predicted_fault is called in an interrupt and therefore must allocate memory using GFP_ATOMIC. Signed-off-by: Anton Blanchard <anton@xxxxxxxxx> Cc: <stable@xxxxxxxxxx> --- Index: linux-work/drivers/scsi/mpt2sas/mpt2sas_scsih.c =================================================================== --- linux-work.orig/drivers/scsi/mpt2sas/mpt2sas_scsih.c 2011-11-07 22:03:33.728865287 +1100 +++ linux-work/drivers/scsi/mpt2sas/mpt2sas_scsih.c 2011-11-07 22:03:39.724972491 +1100 @@ -4330,7 +4330,7 @@ _scsih_smart_predicted_fault(struct MPT2 /* insert into event log */ sz = offsetof(Mpi2EventNotificationReply_t, EventData) + sizeof(Mpi2EventDataSasDeviceStatusChange_t); - event_reply = kzalloc(sz, GFP_KERNEL); + event_reply = kzalloc(sz, GFP_ATOMIC); if (!event_reply) { printk(MPT2SAS_ERR_FMT "failure at %s:%d/%s()!\n", ioc->name, __FILE__, __LINE__, __func__); -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
