Re: [PATCH] Silencing 'killing requests for dead queue'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi James,

On Wed,  9 Nov 2011 08:39:24 +0100 Hannes Reinecke <hare@xxxxxxx> wrote:
>
> When we tear down a device we try to flush all outstanding
> commands in scsi_free_queue(). However the check in
> scsi_request_fn() is imperfect as it only signals that
> we _might start_ aborting commands, not that we've actually
> aborted some.
> So move the printk inside the scsi_kill_request function,
> this will also give us a hint about which commands are aborted.
> 
> Signed-off-by: Hannes Reinecke <hare@xxxxxxx>

Tested-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>

[I realise that you have already committed this fix, but I thought I
should test it anyway.]

ipr_init is now down to 2543495 usecs (down from 494857993 usecs without
this patch) and the machine boots as well as can be expected.
-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgpJKuosLvj1w.pgp
Description: PGP signature


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux