On Fri, Sep 23, 2011 at 3:43 PM, Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
>
> SCSI_ISCI needs to select SCSI_SAS_HOST_SMP to ensure that all
> needed symbols are available to it.
>
> Fixes this build error:
> ERROR: "try_test_sas_gpio_gp_bit" [drivers/scsi/isci/isci.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
Thanks Randy!
Here's a replacement patch (also attached), that just stubs out that
routine in the !SCSI_SAS_HOST_SMP case.
>From 645ea60066251c2728197bf7a1048d885626936f Mon Sep 17 00:00:00 2001
From: Dan Williams <dan.j.williams@xxxxxxxxx>
Date: Fri, 23 Sep 2011 16:28:53 -0700
Subject: [PATCH] libsas: fix try_test_sas_gpio_gp_bit() build error
If the user has disabled CONFIG_SCSI_SAS_HOST_SMP then libsas drivers
will not be receiving smp-gpio frames and do not need this lookup code.
Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
---
include/scsi/libsas.h | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
index 44f5634..0d78bfa 100644
--- a/include/scsi/libsas.h
+++ b/include/scsi/libsas.h
@@ -407,7 +407,14 @@ static inline unsigned int to_sas_gpio_od(int
device, int bit)
return 3 * device + bit;
}
+#ifdef CONFIG_SCSI_SAS_HOST_SMP
int try_test_sas_gpio_gp_bit(unsigned int od, u8 *data, u8 index, u8 count);
+#else
+static inline int try_test_sas_gpio_gp_bit(unsigned int od, u8 *data,
u8 index, u8 count)
+{
+ return -1;
+}
+#endif
/* ---------- Tasks ---------- */
/*
--
1.7.6
Attachment:
0001-libsas-fix-try_test_sas_gpio_gp_bit-build-error.patch
Description: Binary data
