Re: [PATCH] scsi: fix qla2xxx printk format warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 23 Sep 2011 15:40:50 -0700
Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:

> From: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
> 
> sector_t can be different types, so cast it to its largest
> possible type.
> 
> drivers/scsi/qla2xxx/qla_isr.c:1509:5: warning: format '%lx' expects type 'long unsigned int', but argument 5 has type 'sector_t'
> 
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
> ---
>  drivers/scsi/qla2xxx/qla_isr.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- lnx-31-rc7.orig/drivers/scsi/qla2xxx/qla_isr.c
> +++ lnx-31-rc7/drivers/scsi/qla2xxx/qla_isr.c
> @@ -1507,8 +1507,8 @@ qla2x00_handle_dif_error(srb_t *sp, stru
>  
>  			if (k != blocks_done) {
>  				qla_printk(KERN_WARNING, sp->fcport->vha->hw,
> -				    "unexpected tag values tag:lba=%x:%lx)\n",
> -				    e_ref_tag, lba_s);
> +				    "unexpected tag values tag:lba=%x:%llx)\n",
> +				    e_ref_tag, (unsigned long long)lba_s);

The patch does more than fix a warning - that's a runtime bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux