Sparse prints the following warnings:
drivers/target/iscsi/iscsi_target_util.c:1435:32: error: bad constant expression
drivers/target/iscsi/iscsi_target_util.c:1436:30: error: bad constant expression
drivers/target/iscsi/iscsi_target_util.c:1563:32: error: bad constant expression
drivers/target/iscsi/iscsi_target_util.c:1564:30: error: bad constant expression
Here is the offending code:
1430 static int iscsit_do_rx_data(
1431 struct iscsi_conn *conn,
1432 struct iscsi_data_count *count)
1433 {
1434 int data = count->data_length, rx_loop = 0, total_rx = 0, iov_len;
1435 u32 rx_marker_val[count->ss_marker_count], rx_marker_iov = 0;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1436 struct kvec iov[count->ss_iov_count], *iov_p;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1437 struct msghdr msg;
1558 static int iscsit_do_tx_data(
1559 struct iscsi_conn *conn,
1560 struct iscsi_data_count *count)
1561 {
1562 int data = count->data_length, total_tx = 0, tx_loop = 0, iov_len;
1563 u32 tx_marker_val[count->ss_marker_count], tx_marker_iov = 0;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1564 struct kvec iov[count->ss_iov_count], *iov_p;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1565 struct msghdr msg;
To me it looks very dangerous (and potentially exploitable) but I
didn't follow the logic all the way to see what caps are on
->ss_marker_count and ->ss_iov_count.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
