'!' has higher precedence than '&' so the original check only returns if no ->task_flags are set. Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index 8976032..048779c 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -2250,7 +2250,7 @@ void __transport_stop_task_timer(struct se_task *task, unsigned long *flags) { struct se_cmd *cmd = task->task_se_cmd; - if (!task->task_flags & TF_RUNNING) + if (!(task->task_flags & TF_RUNNING)) return; task->task_flags |= TF_STOP; -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html