On Sat, 2011-07-23 at 09:36 -0400, Christoph Hellwig wrote: > On Sat, Jul 23, 2011 at 02:17:17AM -0700, Nicholas A. Bellinger wrote: > > > > #include "target_core_rd.h" > > > > #include "target_core_stat.h" > > > > > > > > +extern struct t10_alua_lu_gp *default_lu_gp; > > > > > > I see here an extern declaration in a .c file. Shouldn't instead that > > > be moved to a header file ? > > > > > > > I don't really have a strong preference here either way, and will defer > > to Andy and Christoph for mainline style consideration on these two > > particular bits.. > > externs should always be in headers. In fact sparse will complain about > having it in the .c file. > Ok, fixing this up now in lio-core-2.6.git and will get this included into the initial merge. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
