On Sat, 2011-07-23 at 10:38 +0200, Fubo Chen wrote: > On Thu, Jul 21, 2011 at 9:04 AM, Nicholas A. Bellinger > <nab@xxxxxxxxxxxxxxx> wrote: > > diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c > > index 03cda0e..82c8e9a 100644 > > --- a/drivers/target/target_core_configfs.c > > +++ b/drivers/target/target_core_configfs.c > > @@ -37,6 +37,7 @@ > > #include <linux/parser.h> > > #include <linux/syscalls.h> > > #include <linux/configfs.h> > > +#include <linux/spinlock.h> > > > > #include <target/target_core_base.h> > > #include <target/target_core_device.h> > > @@ -52,6 +53,8 @@ > > #include "target_core_rd.h" > > #include "target_core_stat.h" > > > > +extern struct t10_alua_lu_gp *default_lu_gp; > > I see here an extern declaration in a .c file. Shouldn't instead that > be moved to a header file ? > I don't really have a strong preference here either way, and will defer to Andy and Christoph for mainline style consideration on these two particular bits.. Thanks for your review! --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
