RE: [PATCH 08/15] bfa: Extend BSG interface.

[Krishna Gudipati <kgudipat@xxxxxxxxxxx>]

-----Original Message-----
From: James Bottomley [mailto:James.Bottomley@xxxxxxxxxxxxxxxxxxxxx] 
Sent: Wednesday, June 29, 2011 3:21 PM
To: Krishna Gudipati
Cc: linux-scsi@xxxxxxxxxxxxxxx; Jing Huang; Adapter Linux Open SRC Team
Subject: Re: [PATCH 08/15] bfa: Extend BSG interface.

On Fri, 2011-06-24 at 20:25 -0700, kgudipat@xxxxxxxxxxx wrote:
>  int
>  bfad_iocmd_ioc_get_pcifn_cfg(struct bfad_s *bfad, void *cmd)
>  {
> @@ -511,27 +986,87 @@ bfad_iocmd_handler(struct bfad_s *bfad, unsigned
> int cmd, void *iocmd,
>         int rc = EINVAL;

This is nastily counterintuitive.  I know it's compensated for by the

return -rc;

But you're creating code confusion here.  Some of your routines now have
a positive error return and some negative.  Can't you just keep it
negative as is the kernel convention?

James

---------

Hi James,

	We will fix this in our next patch-set.

Thanks,
Krishna.

��.n��������+%������w��{.n�����{������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f