Re: [PATCH 08/15] bfa: Extend BSG interface.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2011-06-24 at 20:25 -0700, kgudipat@xxxxxxxxxxx wrote:
>  int
>  bfad_iocmd_ioc_get_pcifn_cfg(struct bfad_s *bfad, void *cmd)
>  {
> @@ -511,27 +986,87 @@ bfad_iocmd_handler(struct bfad_s *bfad, unsigned
> int cmd, void *iocmd,
>         int rc = EINVAL;

This is nastily counterintuitive.  I know it's compensated for by the

return -rc;

But you're creating code confusion here.  Some of your routines now have
a positive error return and some negative.  Can't you just keep it
negative as is the kernel convention?

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux