On Fri, 2011-06-24 at 20:25 -0700, kgudipat@xxxxxxxxxxx wrote:
> int
> bfad_iocmd_ioc_get_pcifn_cfg(struct bfad_s *bfad, void *cmd)
> {
> @@ -511,27 +986,87 @@ bfad_iocmd_handler(struct bfad_s *bfad, unsigned
> int cmd, void *iocmd,
> int rc = EINVAL;
This is nastily counterintuitive. I know it's compensated for by the
return -rc;
But you're creating code confusion here. Some of your routines now have
a positive error return and some negative. Can't you just keep it
negative as is the kernel convention?
James
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
