On Wed, Jun 15, 2011 at 10:25 AM, Nicholas A. Bellinger <nab@xxxxxxxxxxxxxxx> wrote: > Actually, it's only two places: core_tmr_release_req() and > core_tmr_lun_reset() > >> Presumably se_tmr_lock is taken from process context sometimes? >> So we would need to convert all those spin_lock()s to spin_lock_irq() >> (or irqsave I guess). > > Correct, both of the above are only every called from process context, > so a simple conversion to spin_lock_irq() for these two, and > spin_lock_irqsave() in transport_lookup_tmr_lun() should by sufficent.. Looking at this... core_tmr_lun_reset() uses _irqsave locking for cmd->t_state_lock... is that not needed, or can it actually be called from a context where we can't just use spin_lock_irq? (eg because some caller might have already disabled interrupts) - R. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
