Re: [PATCH] target: Make transport_lookup_cmd_lun() locking IRQ-safe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 15, 2011 at 10:06 AM, Nicholas A. Bellinger
<nab@xxxxxxxxxxxxxxx> wrote:
> Btw, I think the same type of conversion may need to happen for
> transport_lookup_tmr_lun() as well, as I believe qla_target.c can call
> this directly from interrupt context in certain situations.

Yes, I think I sent another mail about this... the reason I didn't just
send a patch is that transport_lookup_tmr_lun() ends with:

        spin_lock(&se_tmr->tmr_dev->se_tmr_lock);
        list_add_tail(&se_tmr->tmr_list, &se_tmr->tmr_dev->dev_tmr_list);
        spin_unlock(&se_tmr->tmr_dev->se_tmr_lock);

and indeed se_tmr_lock looks like it is taken with bare spin_lock()
in lots of places.

Presumably se_tmr_lock is taken from process context sometimes?
So we would need to convert all those spin_lock()s to spin_lock_irq()
(or irqsave I guess).

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux