On Thu, May 26, 2011 at 02:00:21AM -0700, Xiangliang Yu wrote: > > >Subject: Re: [PATCH 3/9] [SCSI] mvsas: Add driver version and interrupt >coalescing to device attributes in sysfs > >> > >> -- Add support for driver version and interrupt coalescing device attributes. > > >When you add a sysfs file, you must also add a Documentation/ABI file as > >well. Please do that here. > > These device attributes are sysft class properties for the scsi host, > and the sysfs files are within scsi host sysfs directory. so, do you > think I need add a ABI file? and , I can't find anything about scsi > host sysfs file under directory Documentation/ABI. Yes, again, if you add a sysfs file, you need to add documentation explaining exactly what it is there for and what it does. And if there isn't already a file for this device, then please add it. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html