On Wed, May 25, 2011 at 12:52 PM, Parag Warudkar <parag.lkml@xxxxxxxxx> wrote:
>
> +static inline int sdev_early_check(struct scsi_device *sdev)
> +{
> + if (!sdev || sdev->sdev_state == SDEV_DEL
> + || sdev->sdev_state > SDEV_QUIESCE)
> + return -ENXIO;
> + return 0;
> +}
Can somebody explain why it's those states, and nothing else?
Quite frankly, if it's about "don't oops on sdev->queue not existing",
then test for that. Not for some random and uncommented list of
states.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
