On 2011-05-25 20:55, Linus Torvalds wrote: > On Wed, May 25, 2011 at 11:44 AM, Parag Warudkar <parag.lkml@xxxxxxxxx> wrote: >> >> Below patch pushes the check down to ioctl functions and hopefully should >> cover more ioctl-on-gone-device cases by returning -ENXIO if an attempt >> was made to submit request to a non-running device. > > Can we please not duplicate complicated logic like that? > > IOW, just make a helper function for it. > > That said, isn't this all *exactly* what scsi_prep_state_check() is > supposed to check for? Why isn't that called, or if called, why isn't > it doing the right thing? This is before you get that far, it's actually oopsing on inserting the request on sdev->sdev_queue that is now NULL. The prep state checking happens when sr/sd pulls the request off the queue for processing. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
