>-----Original Message----- >From: Mike Christie [mailto:michaelc@xxxxxxxxxxx] >Sent: Tuesday, April 19, 2011 8:11 AM >To: Vikas Chaudhary >Cc: James.Bottomley@xxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; open- >iscsi@xxxxxxxxxxxxxxxx; Lalit Chandivade; Ravi Anand >Subject: Re: [RFC-V2 PATCH 4/5] iscsi_transport: show network configuration >in sysfs > >Just noticed I forgot to send some comments. > >On 04/02/2011 01:34 PM, vikas.chaudhary@xxxxxxxxxx wrote: >> | >> |- ipv4-iface-<host_no>-<iface_no>/<-- for ipv4 >> |- ipaddress >> |- subnet >> |- gateway >> |- bootproto >> |- state > >What does state mean? I thought it was going to be something like port >up/down/coming up/ or something like that. It instead just indicates if >it is enabled or not, right? > Yes, state indicates ipv4/ipv6 enabled or not. >What about > >1. renaming to enabled, having it print out True of enabled and False if >not. >2. adding a new file for state that indicates the port's state. >3. rename IPOPT_IPv4_PROTOCOL_ENABLE to IPOPT_IPV4_PROTOCOL_ENABLE to >match ipv6 naming. Ok. I will take care of all three comments in final patch. This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
