Re: [RFC-V2 PATCH 4/5] iscsi_transport: show network configuration in sysfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Just noticed I forgot to send some comments.

On 04/02/2011 01:34 PM, vikas.chaudhary@xxxxxxxxxx wrote:
|
|- ipv4-iface-<host_no>-<iface_no>/<-- for ipv4
                                 |- ipaddress
                                 |- subnet
                                 |- gateway
                                 |- bootproto
                                 |- state

What does state mean? I thought it was going to be something like port up/down/coming up/ or something like that. It instead just indicates if it is enabled or not, right?

What about

1. renaming to enabled, having it print out True of enabled and False if not.
2. adding a new file for state that indicates the port's state.
3. rename IPOPT_IPv4_PROTOCOL_ENABLE to IPOPT_IPV4_PROTOCOL_ENABLE to match ipv6 naming.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux