On Sun, 2011-04-03 at 07:00 -0400, Christoph Hellwig wrote: > On Sat, Apr 02, 2011 at 03:02:40PM -0600, Matthew Wilcox wrote: > > Fair enough, but you're making the perfect the enemy of the good. > > How about putting this patch in for now (since it harms nothing), and > > then it'll all go away when you delete cmd_serial_number? > > If you change it anyway for mpt2sas just keep the atomic counter in > it's local structures. Or even better verify with LSI if the > serial_number check can't simply be removed entirely, which I think it > could. Also I'm not really sure atomic counter conversion is the correct thing to do. Someone from intel said it would perform worse than the current spinlock based serial number the last time we discussed the conversion (converting it to atomic was my first thought at the time). James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
