On Sat, Apr 02, 2011 at 09:36:43AM -0400, Christoph Hellwig wrote: > On Fri, Apr 01, 2011 at 04:20:51PM -0400, Matthew Wilcox wrote: > > > > In preparation for moving some drivers out from under the host_lock, > > make cmd_serial_number an atomic. > > The right fix is to stop abusing cmd_serial_nubmer in those few > drivers, and use a driver-private and more scalable lookup data > structure than a linear list search. > > And yes, I promised to at least move cmd_serial_number into these > drivers long time ago - time to get back to that. Fair enough, but you're making the perfect the enemy of the good. How about putting this patch in for now (since it harms nothing), and then it'll all go away when you delete cmd_serial_number? -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
