On Mon, Mar 28, 2011 at 6:20 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > Start killing off the pointless sci_base* structures which do nothing > but causing a lot of unreadable code by converting forth and back > between them and the real structures. > > I've done the sci_base_controller, and sci_base_request on a rainy > sunday afternoon, but the port, phy and remote device also need the > same treatment. And after that the sci_base_object crap needs to > go in favour of just using container_of or properly typed pointers. > > But I'll rather leave that to you Intel guys, spending more time > on this codebase won't be good for my mental health. Understood, but it's not everyday you get to submit patches that consistently have a 2x deletions/insertions ratio. In fact that has been my rule of thumb for this driver for a while, any cleanup patch that falls short of that ratio is probably too narrow of a cleanup. -- Dan -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
