Re: [PATCH] scic: remove mmio wrappers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 27, 2011 at 5:07 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> Remove a couple of layers around read/writel to make the driver readable.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Thanks!

Smoketests ok, applied, but without the hunk below, which gives away
the fact that this was automated to some extent.

> Index: linux-2.6/drivers/scsi/isci/core/scic_sds_unsolicited_frame_control.c
> ===================================================================
> --- linux-2.6.orig/drivers/scsi/isci/core/scic_sds_unsolicited_frame_control.c  2011-03-28 01:40:43.704981485 +0200
> +++ linux-2.6/drivers/scsi/isci/core/scic_sds_unsolicited_frame_control.c       2011-03-28 01:41:14.336982622 +0200
> @@ -317,8 +317,8 @@ enum sci_status scic_sds_unsolicited_fra
>  * This method returns an indication to the caller as to whether the
>  * unsolicited frame get pointer should be updated. true This value indicates
>  * the unsolicited frame get pointer should be updated (i.e. write
> - * SCU_UFQGP_WRITE). false This value indicates the get pointer should not be
> - * updated.
> + * scu_registers->sdma.unsolicited_frame_get_pointer).
> + * false This value indicates the get pointer should not be updated.
>  */

Do you mind sharing the script you used to perform this conversion?  I
have a growing collection of hacked together cleanup tools from this
effort and would like to add this one.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux