I was on leave, sorry for the delay. I reinspected the patch and it looks good IMHO. A global name ALIGN32 may have been a bit presumptuous (AAC_ALIGN32?) but there is no collisions with existing upstream definitions within the Linux source tree so No Big Deal. Drivers/net/wan/wanxl.h also presumptuously used an ALIGN32() definition so there is precedence. This room is clean :-) Sincerely -- Mark Salyzyn -----Original Message----- From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi-owner@xxxxxxxxxxxxxxx] On Behalf Of Mahesh Rajashekhara Sent: Thursday, March 17, 2011 5:11 AM To: James.Bottomley@xxxxxxx; linux-scsi@xxxxxxxxxxxxxxx Cc: aacraid@xxxxxxxxxxxxxx; Achim Leubner; Tony Ruiz Subject: RE: [PATCH 1/1] AACRAID driver update patch version - 28000 Hi James, Thanks for your comments. We have added the changes suggested by Mark Salyzyn in this driver patch. . . . ______________________________________________________________________ This email may contain privileged or confidential information, which should only be used for the purpose for which it was sent by Xyratex. No further rights or licenses are granted to use such information. If you are not the intended recipient of this message, please notify the sender by return and delete it. You may not use, copy, disclose or rely on the information contained in it. Internet email is susceptible to data corruption, interception and unauthorised amendment for which Xyratex does not accept liability. While we have taken reasonable precautions to ensure that this email is free of viruses, Xyratex does not accept liability for the presence of any computer viruses in this email, nor for any losses caused as a result of viruses. Xyratex Technology Limited (03134912), Registered in England & Wales, Registered Office, Langstone Road, Havant, Hampshire, PO9 1SA. The Xyratex group of companies also includes, Xyratex Ltd, registered in Bermuda, Xyratex International Inc, registered in California, Xyratex (Malaysia) Sdn Bhd registered in Malaysia, Xyratex Technology (Wuxi) Co Ltd registered in The People's Republic of China and Xyratex Japan Limited registered in Japan. ______________________________________________________________________ -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html