On Thu, 2011-02-24 at 20:56 -0800, adam radford wrote: > James/Linux-scsi, > > The following patch for megaraid_sas fixes a megasas_get_cmd printk. > > Signed-off-by: Adam Radford <aradford@xxxxxxxxx> > > diff -Naur scsi-misc-2.6/drivers/scsi/megaraid/megaraid_sas_base.c > scsi-misc-2.6.new/drivers/scsi/megaraid/megaraid_sas_base.c > --- scsi-misc-2.6/drivers/scsi/megaraid/megaraid_sas_base.c 2011-02-24 > 18:49:07.531369391 -0800 > +++ scsi-misc-2.6.new/drivers/scsi/megaraid/megaraid_sas_base.c 2011-02-24 > 18:49:45.987337951 -0800 > @@ -186,7 +186,8 @@ > struct megasas_cmd, list); > list_del_init(&cmd->list); > } else { > - printk(KERN_ERR "megasas: Command pool empty!\n"); > + if (megasas_dbg_lvl) > + printk(KERN_ERR "megasas: Command pool empty!\n"); Why not just use KERN_DEBUG instead of KERN_ERR here and forget the if (megasas_dbg_lvl)? James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html