On Thu, 2011-02-24 at 16:58 -0800, Nicholas A. Bellinger wrote: > atomic_set(&task->task_stop, 0); > + } else { > + if (atomic_read(&task->task_execute_queue) != 0) > + transport_remove_task_from_execute_queue(task, dev); You've done this twice in this patch; just for future reference, it's better written as } else if (atomic_read(&task->task_execute_queue) != 0) { transport_remove_task_from_execute_queue(task, dev); } Which avoids the double indentation. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html