Re: [PATCH-FOR-38] target: Fix t_transport_aborted handling in LUN_RESET + active I/O shutdown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2011-02-24 at 16:58 -0800, Nicholas A. Bellinger wrote:
> 			atomic_set(&task->task_stop, 0);
> +		} else {
> +			if (atomic_read(&task->task_execute_queue) != 0)
> +				transport_remove_task_from_execute_queue(task, dev);

You've done this twice in this patch; just for future reference, it's
better written as

} else if (atomic_read(&task->task_execute_queue) != 0) {
	transport_remove_task_from_execute_queue(task, dev);
}

Which avoids the double indentation.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux