> -----Original Message----- > From: Matthew Garrett [mailto:mjg@xxxxxxxxxx] > Sent: Wednesday, February 09, 2011 12:07 PM > To: mjg@xxxxxxxxxx > Cc: Miller, Mike (OS Dev); ISS StorageDev; linux-scsi@xxxxxxxxxxxxxxx > Subject: [PATCH 2/2] cciss: Disable ASPM > > https://bugzilla.redhat.com/show_bug.cgi?id=618612 indicates that > current > hpsa hardware has problems if ASPM is enabled. Disable it to avoid > crashes. ASPM is supposed to be fixed on both Proliant and Smart Array by the next generation of hardware. If that comes to fruition I suppose we could make this patch conditional based on whether the underlying hw really supports ASPM. Other than that this looks good. Matthew, if Proliant BIOS tells the OS that ASPM is not supported does the OS honor that and not attempt to use ASPM? I know there was a time (maybe still is) when that bit in the ACPI table was not being set so rhel6 tried to use ASPM and hence the BZ you mention. Sorry, but I can't recall the proper terminology for the ACPI table related stuff. -- mikem > > Signed-off-by: Matthew Garrett <mjg@xxxxxxxxxx> > Cc: Mike Miller <mike.miller@xxxxxx> > Cc: iss_storagedev@xxxxxx > Cc: linux-scsi@xxxxxxxxxxxxxxx > --- > drivers/block/cciss.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c > index 516d5bb..bb77666 100644 > --- a/drivers/block/cciss.c > +++ b/drivers/block/cciss.c > @@ -24,6 +24,7 @@ > #include <linux/interrupt.h> > #include <linux/types.h> > #include <linux/pci.h> > +#include <linux/pci-aspm.h> > #include <linux/kernel.h> > #include <linux/slab.h> > #include <linux/delay.h> > @@ -4561,6 +4562,9 @@ static int __devinit cciss_init_one(struct pci_dev > *pdev, > InquiryData_struct *inq_buff; > ctlr_info_t *h; > > + pci_disable_link_state(pdev, PCIE_LINK_STATE_L0S | > PCIE_LINK_STATE_L1 | > + PCIE_LINK_STATE_CLKPM); > + > rc = cciss_init_reset_devices(pdev); > if (rc) > return rc; > -- > 1.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
