Re: [PATCH 2/3] target: simplify cmd to task mapping

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/22/2010 11:07 PM, Christoph Hellwig wrote:
> On Thu, Nov 18, 2010 at 02:07:17PM +0200, Boaz Harrosh wrote:
>> If all these are mutual exclusive (if..elseif..else) can we not make
>> them an enum and switch() for costless-ness and clarity?
> 
> We could.  But IMHO we should simply get rid of all the special cases
> instead.  First remove the non-SG case, then fold the zero transfer
> length one in as a special zero-length SG and then check how many
> differences we have left between the data and control plane.
> 

ACK ^3

Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux