On Thu, Nov 18, 2010 at 02:07:17PM +0200, Boaz Harrosh wrote: > If all these are mutual exclusive (if..elseif..else) can we not make > them an enum and switch() for costless-ness and clarity? We could. But IMHO we should simply get rid of all the special cases instead. First remove the non-SG case, then fold the zero transfer length one in as a special zero-length SG and then check how many differences we have left between the data and control plane. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html