On Tue, 2010-11-09 at 05:03 -0500, Christoph Hellwig wrote: > > + opts = kstrdup(page, GFP_KERNEL); > > What do you need the this copy for? > > Otherwise looks good. > <nod> thanks for the pointer here.. Btw, the kstrdup() is required because the configfs attribute store function will be passing a 'const char *page' that is propigated from target_core_configfs.c: target_core_store_dev_control() out to ->set_configfs_dev_params() backend code. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
