> + opts = kstrdup(page, GFP_KERNEL); What do you need the this copy for? Otherwise looks good. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html