On Mon, 2010-11-08 at 16:48 -0500, Christoph Hellwig wrote: > On Mon, Nov 08, 2010 at 01:20:07PM -0800, Nicholas A. Bellinger wrote: > > Hmmm, it is my understanding that seq_file is currently not available > > for configfs. Also, we never going to expect these particular calls to > > return anything close to PAGE_SIZE, so I am not sure how much of an > > issue this really is. > > Seq_file is avaible for anything where you can plug in file_operations. > If configfs doesn't allow plugging in file_operations that's a serious > deficit. If you need less than a page of data single_open provides a > simplified version of seq_file with a similar but much simpler API. Hmmm, I recall asking Joel about this at some point back in 2008 and back then I believe configfs was still limited to a PAGE_SIZE. Joel, any comments here on the usage of seq_file() w/ configfs..? > > > > - the set_configfs_dev_params method implementation contains some > > > rather nast parsing code. They look like they really should use > > > the parser.h helpers we use for mount option parsing. > > > > <nod> This code current expects the the incoming buffer to be in the > > form of 'key0=value0,key1=value1,key2=value2' etc. Assuming that > > parser.h code can handle the comma seperated values, I will look at > > getting these converted as well. > > That's exactly how mount options work. > <nod> Ok, I will get this code converted to use parser.h. --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
