Some comments on the configfs to backend API: - the various get_*_info methods look like they really should use the seq_file API. That gives you safety against overflows, and simplifies the code. - why are show_configfs_dev_params and get_dev_info separate methods if they always end up calling the same code? - the set_configfs_dev_params method implementation contains some rather nast parsing code. They look like they really should use the parser.h helpers we use for mount option parsing. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html